Skip to content

Autotools: Quote AC_CHECK_LIB arguments #15116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 27, 2024
Merged

Conversation

petk
Copy link
Member

@petk petk commented Jul 26, 2024

This syncs CS for AC_CHECK_LIB where possible, and adds minor help texts to gettext extension AC_DEFINE symbols, including the HAVE_LIBINTL.

This syncs CS for AC_CHECK_LIB where possible, and adds minor help texts
to gettext extension AC_DEFINE symbols, including the HAVE_LIBINTL.
@petk
Copy link
Member Author

petk commented Jul 26, 2024

I've just remembered that Autoconf 2.72 really might have issues with these quotes. There was even a bug reported in the past due to these being unquoted (specially in AC_CHECK_LIB being wrapped unquoted inside another AC_CHECK_LIB for example), so I think that it's only proper to fully sync these quotes across the build system where possible.

@petk petk merged commit c53b272 into php:master Jul 27, 2024
9 of 11 checks passed
@petk petk deleted the patch-AC_CHECK_LIB branch July 27, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants